Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Always keep FunctionLikeStorage->param_lookup in sync #6054

Merged
merged 3 commits into from
Jul 9, 2021
Merged

fix: Always keep FunctionLikeStorage->param_lookup in sync #6054

merged 3 commits into from
Jul 9, 2021

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Jul 6, 2021

Fixes #6050.

@caugner caugner marked this pull request as ready for review July 6, 2021 09:55
@caugner caugner changed the title Extract FunctionLikeStorage::setParams()/addParam() Always keep FunctionLikeStorage->param_lookup in sync Jul 6, 2021
@caugner caugner changed the title Always keep FunctionLikeStorage->param_lookup in sync fix: Always keep FunctionLikeStorage->param_lookup in sync Jul 6, 2021
@caugner caugner mentioned this pull request Jul 6, 2021
Closed
@caugner
Copy link
Contributor Author

caugner commented Jul 8, 2021

@weirdan Is it an acceptable approach to have those methods setParams() and addParam() on the FunctionLikeStorage? Maybe I should mark them as @internal?

weirdan
weirdan requested changes Jul 8, 2021
View reviewed changes
Copy link
Collaborator

@weirdan weirdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I should mark them as @internal?

Yes, please do.

@caugner caugner requested a review from weirdan July 8, 2021 22:59
@weirdan weirdan merged commit f94f3b8 into vimeo:master Jul 9, 2021
@weirdan
Copy link
Collaborator

weirdan commented Jul 9, 2021

Thanks!

@caugner caugner deleted the 6050-FunctionLikeAnalyzer-extract-setParams-addParam branch October 1, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weirdan weirdan weirdan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FunctionLikeAnalyzer: params & param_lookup are not always symetrical
2 participants
@caugner @weirdan