Fix #6061 — delay analysis of array value except when unpacking #6081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right, makes sense and it's more readable. Thanks! |
|
Does this also fix the UnusedVariable issue? Can you point me the solution if it does? |
Yes, see attached test! Changing the order of analysis is all that's necessary for the control-flow issues to be resolved. The bug was that values were analysed before keys, which also screws up variable use detection. |
I must have messed up somewhere then, My solution still had UnusedVariable issue even though I inverted the value and key analysis. Thanks for the explanation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This undoes a mistake made in 3f2d57c.
cc @orklah — I think this fix is preferable to yours (unless there's something I've missed)