added dataflow to stringy bitwise op, bitwise not op (fix #5957) #6084
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
Fixes #5957
It appears addDataFlow was never called for bitwise operators with stringy (hasString() == true) operands.
And I could not find an implementation of "addDataflow" for unary operators, so I added one in BitwiseNotAnalyzer.
Added snippets from the original issue as a test and ran psalm on brick/math - no more UnusedVariable errors.