shell_exec can return false

[VincentLanglet]

Related to phpstan/phpstan#5376 (reply in thread)
Seems like unlike is saying the php documentation, shell_exec can return false php/php-src#7306

But psalm consider the return type to be string|null
https://psalm.dev/r/36a3eb5fa8

Where should I update the return type definition ?

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/36a3eb5fa8

<?php

function foo(string $s): bool {
    /** @psalm-suppress ForbiddenCode */
    return false !== shell_exec($s);
}

Psalm output (using commit 82dfbbc):

ERROR: RedundantCondition - 5:12 - null|string can never contain false

[weirdan]

Where should I update the return type definition ?

Just dictionaries/CallMap.php (no changes to deltas are required).

[VincentLanglet]

Thanks, #6178