Forbid empty()

[ro0NL]

I tried

    <forbiddenFunctions>
        <function name="dd"/>
        <function name="dump"/>
        <function name="empty"/>
    </forbiddenFunctions>

without success. I know empty() is a language construct, but to me it's just a function :}

[psalm-github-bot]

Hey @ro0NL, can you reproduce the issue on https://psalm.dev ?

[ro0NL]

https://psalm.dev/r/64501b6f92

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/64501b6f92

<?php
var_dump('booooo');
empty('yayyyy');

Psalm output (using commit eb973ab):

ERROR: ForbiddenCode - 2:1 - Unsafe var_dump

[weirdan]

but to me it's just a function

It's not to php parser though. Should be fairly easy to add in src/Psalm/Internal/Analyzer/Statements/Expression/EmptyAnalyzer.php, similar to how it's done for print():

psalm/src/Psalm/Internal/Analyzer/Statements/Expression/PrintAnalyzer.php

Lines 75 to 85 in eb973ab

	if (isset($codebase->config->forbidden_functions['print'])) {
	if (IssueBuffer::accepts(
	new ForbiddenCode(
	'You have forbidden the use of print',
	new CodeLocation($statements_analyzer->getSource(), $stmt)
	),
	$statements_analyzer->getSuppressedIssues()
	)) {
	// continue
	}
	}