Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSpell resources have been converted to objects #6408

Closed
Tracked by #6395
weirdan opened this issue Sep 4, 2021 · 3 comments · Fixed by #6569
Closed
Tracked by #6395

PSpell resources have been converted to objects #6408

weirdan opened this issue Sep 4, 2021 · 3 comments · Fixed by #6569
Assignees
@tomasnorre
Labels
easy problems Issues that can be fixed without background knowledge of Psalm good first issue Help wanted internal stubs/callmap
Milestone
PHP 8.1

Comments

@weirdan
Copy link
Collaborator

weirdan commented Sep 4, 2021 •
edited

  • The PSpell functions now accept and return, respectively, PSpell\Dictionary objects instead of pspell resources.
  • The PSpell functions now accept and return, respectively, PSpell\Config objects instead of pspell config resources.

Guide to editing callmaps: Editing callmaps.
Example of conversion: #6421
@weirdan weirdan mentioned this issue Sep 4, 2021
Closed
25 tasks
@psalm-github-bot
Copy link

Hey @weirdan, can you reproduce the issue on https://psalm.dev ?

@weirdan weirdan added easy problems Issues that can be fixed without background knowledge of Psalm Help wanted internal stubs/callmap good first issue labels Sep 4, 2021
@weirdan weirdan added this to the PHP 8.1 milestone Sep 4, 2021
@tomasnorre
Copy link
Contributor

You can assign me to this one too @weirdan @orklah then I'll give it a spin too tonight.

@tomasnorre tomasnorre mentioned this issue Oct 2, 2021
Merged
@tomasnorre
Copy link
Contributor

I took the liberty to do the PR without being assigned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomasnorre tomasnorre

Labels
easy problems Issues that can be fixed without background knowledge of Psalm good first issue Help wanted internal stubs/callmap
Projects
None yet
Milestone
PHP 8.1
Development

Successfully merging a pull request may close this issue.

Convert PSpell resources to objects tomasnorre/psalm
2 participants
@weirdan @tomasnorre