Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fiber stubs #6422

Closed
Tracked by #6395
weirdan opened this issue Sep 4, 2021 · 2 comments · Fixed by #6614
Closed
Tracked by #6395

Fiber stubs #6422

weirdan opened this issue Sep 4, 2021 · 2 comments · Fixed by #6614
Assignees
Labels
easy problems Issues that can be fixed without background knowledge of Psalm Help wanted internal stubs/callmap
Milestone

Comments

@weirdan
Copy link
Collaborator

weirdan commented Sep 4, 2021

https://wiki.php.net/rfc/fibers

https://github.com/php/php-src/blob/master/Zend/zend_fibers.stub.php

@weirdan weirdan added this to the PHP 8.1 milestone Sep 4, 2021
@weirdan weirdan added easy problems Issues that can be fixed without background knowledge of Psalm good first issue Help wanted internal stubs/callmap and removed good first issue labels Sep 4, 2021
@ishanvyas22
Copy link
Contributor

Hey, I would like to work on this. I think here we have to add stubs for class and methods in stubs/Php81.phpstub file and delta file at dictionaries/CallMap_81_delta.php.

Can you please assign this issue to me?

@orklah
Copy link
Collaborator

orklah commented Oct 3, 2021

Hi @ishanvyas22 ! Great! Stubs are used to describe complex behaviour in methods so they're not always needed. I have very little knowledge about fibers though so it may be the case here.

Here's some documentation about editing Callmaps: https://psalm.dev/docs/contributing/editing_callmaps/ You'll find that you have to edit Callmap.php too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy problems Issues that can be fixed without background knowledge of Psalm Help wanted internal stubs/callmap
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants