[TAINT] report invalid psalm-taint-sink

[staabm]

would be great, psalm would error when using psalm-taint-sink without providing the param name.

this should error

/**
 * @psalm-taint-sink sql
 */
fuction query($query) {
}

because it is missing the $query:

done right it would be:

/**
 * @psalm-taint-sink sql $query
 */
fuction query($query) {
}

I feel from a DX perspective it should be handled similar to forgetting the parameter reference in a @param

[orklah]

That should be easy to change here:

psalm/src/Psalm/Internal/PhpVisitor/Reflector/FunctionLikeDocblockParser.php

Line 210 in a2d6861

if (count($param_parts) >= 2) {

You should be able to throw a IncorrectDocblockException here to make sure this case doesn't happen

[staabm]

Will send a PR tomorrow

[weirdan]

Will send a PR tomorrow

@staabm It must have been lost somewhere; feel free to resend 😁

[staabm]

thanks for the reminder

;-)