Forbid use positional argument after named argument

[klimick]

This code will fail with fatal error: https://3v4l.org/14hEF#v8.0.13

<?php

final class Person
{
    public function __construct(
        public string $name,
        public int $age,
    ) { }
}

new Person(name: '', 0);

It would be nice if Psalm report about it:
https://psalm.dev/r/b0ed47490d

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/b0ed47490d

<?php

final class Person
{
	public function __construct(
    	public string $name,
        public int $age,
    ) { }
}

new Person(name: '', 0);

Psalm output (using commit 8bd525a):

No issues!

[weirdan]

Yeah, that would be nice. It's not a pressing issue though, as it can be detected with php -l.

[orklah]

It should be quite easy though. Arguments are handled here:

psalm/src/Psalm/Internal/Analyzer/Statements/Expression/Call/ArgumentsAnalyzer.php

Line 650 in 39402c2

foreach ($args as $argument_offset => $arg) {

This is a loop that checks each argument for matching purposes (types must match, numbers must match, named argument must match, etc...)

And here:

psalm/src/Psalm/Internal/Analyzer/Statements/Expression/Call/ArgumentsAnalyzer.php

Line 714 in 39402c2

} elseif ($arg->name && (!$function_storage || $function_storage->allow_named_arg_calls)) {

Psalm spots a named argument while looping. I guess it should only be a matter of creating a local variable flag set to true when seeing the first named argument, and then emitting an issue on the next loop if the arg is not named.

InvalidArgument should do nicely I think