Psalm 5: crash with references

[pilif]

https://psalm.dev/r/0bb7071d6d

Uncaught Error: Attempt to modify property "parent_nodes" on null in <project>/vendor/vimeo/psalm/src/Psalm/Internal/Analyzer/Statements/Expression/AssignmentAnalyzer.php:975

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/0bb7071d6d

<?php

function func(&$a)
{
    $_ = &$a['f'];
}

Psalm encountered an internal error:

/vendor/vimeo/psalm/src/Psalm/Internal/Analyzer/Statements/Expression/AssignmentAnalyzer.php: Attempt to modify property "parent_nodes" on null

[AndrolGenhald]

It looks like this is because analyzing $a['f'] doesn't add $a['f'] to $vars_in_scope if it's mixed. This works fine. I'll get it fixed shortly.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/c0d3beb032

<?php

/**
 * @param array{f: int} $a
 */
function func(&$a)
{
    $b = &$a['f'];
}

Psalm output (using commit c5722dd):

INFO: UnusedVariable - 8:5 - $b is never referenced or the value is not used

INFO: UnusedParam - 6:16 - Param $a is never referenced in this method

INFO: MissingReturnType - 6:10 - Method func does not have a return type, expecting void