Psalm could not infer this type being passed inside the php8 attribute

[taras-pinchuk-uinno]

Psalm version: 4.20.0
Php version: 8.1

Error ouptput:

ERROR: InvalidArgument - app/Requests/UpdateUserRequest.php:43:17 - Argument 7 of OpenApi\Attributes\Patch::__construct expects array<array-key, OpenApi\Attributes\Parameter>|null, array{"Psalm could not infer this type"} provided (see https://psalm.dev/004)
    parameters: [
        new Parameter(name: 'id', description: 'User ID', in: 'path', required: true),
 ],

[psalm-github-bot]

Hey @taras-pinchuk-uinno, can you reproduce the issue on https://psalm.dev ?

[taras-pinchuk-uinno]

Hey @taras-pinchuk-uinno, can you reproduce the issue on https://psalm.dev ?

Yes, https://psalm.dev/r/344b174fa6

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/344b174fa6

<?php

#[Attribute]
class B{
     public function __construct(
    ?array $listOfB = null
){
 }
}

#[Attribute(Attribute::TARGET_CLASS)]
class A {
    /**
    * @param B[] $listOfB
  	 **/
 public function __construct(
    ?array $listOfB = null
){
 }
}

//That doesnt works
#[A([new B])]
class C{
}

//This Work
new A([new B]);

Psalm output (using commit 1ee7648):

ERROR: InvalidArgument - 23:5 - Argument 1 of A::__construct expects array<array-key, B>|null, array{'Psalm could not infer this type'} provided

[AndrolGenhald]

Two issues here, first, we probably shouldn't be using StubsGenerator::getExpressionFromType outside of stub generation if it returns a literal string 'Psalm could not infer this type' instead of mixed when it fails, second, this shouldn't be failing anyway.

[morrgot]

facing same problem, while trying to build api documentation with "zircote/swagger-php":

use OpenApi\Attributes as OA;

class GetProductController
{
    #[OA\PathParameter(
        parameter: "productId",
        name: "productId",
        description: "Product Id, to get information about",
        schema: new OA\Schema(
            format: "uuid"
        )
    )]
    public function __invoke(Request $request): Response
    {
    }
}

I get
Argument 4 of OpenApi\Attributes\PathParameter::__construct expects OpenApi\Attributes\Schema|null, "Psalm could not infer this type" provided

[sokil]

This bug introduced in 4.20.0

    use OpenApi\Attributes as OA;

    #[OA\Parameter(
        schema: new OA\Schema(),
    )]
    public function __invoke(Request $request): Response {}

Problem occured at vendor/vimeo/psalm/src/Psalm/Internal/Analyzer/AttributeAnalyzer.php

            if ($type->isMixed()) {
                return;
            }

            $type_expr = StubsGenerator::getExpressionFromType(
                $type
            );

On version 4.19.0:

object(Psalm\Type\Union)#132719 (27) {
  ["types":"Psalm\Type\Union":private]=>
  array(1) {
    ["mixed"]=>
    object(Psalm\Type\Atomic\TMixed)#132715 (6) {
      ["checked"]=>
      bool(false)
      ["from_docblock"]=>
      bool(false)
      ["offset_start"]=>

On version 4.20.0

object(Psalm\Type\Union)#132693 (27) {
  ["types":"Psalm\Type\Union":private]=>
  array(1) {
    ["OpenApi\Attributes\Schema"]=>
    object(Psalm\Type\Atomic\TNamedObject)#132694 (9) {
      ["checked"]=>
      bool(false)
      ["from_docblock"]=>
      bool(false)
      ["offset_start"]=>
      NULL
      ["offset_end"]=>

But \Psalm\Internal\Stubs\Generator\StubsGenerator::getExpressionFromType does not know about TNamedObject.

So, downgrate to 4.19.0 may fix the problem temporary