InvalidClass does not work PHP native classes and stubs

[kkmuffme]

https://psalm.dev/r/a2caa7560a

When class Hello is not in the project files but provided via stubs, it doesn't report InvalidClass error.
This is true for global (psalm provided) and custom (user/config provided) stubs.

e.g. DateTime:
https://psalm.dev/r/78f1f31d1b

Should give an InvalidClass error too

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/a2caa7560a

<?php

class Hello {
    
}

/**
 * @param hello $arg
 * @return void
 */
function abc( $arg ) {
    
}

Psalm output (using commit afe85fa):

ERROR: InvalidClass - 8:11 - Class, interface or enum hello has wrong casing

INFO: UnusedParam - 11:15 - Param $arg is never referenced in this method

https://psalm.dev/r/78f1f31d1b

<?php

/**
 * @param dateTime $arg
 * @return void
 */
function abc( $arg ) {
    
}

Psalm output (using commit afe85fa):

INFO: UnusedParam - 7:15 - Param $arg is never referenced in this method

[kkmuffme]

Issue is bc ClassLikes.php public function classHasCorrectCasing ironically uses strtolower on classlike_aliases:

if (isset($this->classlike_aliases[strtolower($fq_class_name)])) {

which is necessary to check if the class exists. But not sufficient to check here.

Afaik changing this:

if (isset($this->classlike_aliases[strtolower($fq_class_name)])) {
    return true;
}

to:

if (isset($this->classlike_aliases[strtolower($fq_class_name)]) && $this->classlike_aliases[strtolower($fq_class_name)] === $fq_class_name) {
    return true;
}

should be enough to fix this
(same for interface/enum in functions after it)

Additionally
if ($codebase->classlikes->isUserDefined(strtolower($aliased_name))) { before new InvalidClass should be removed too?

Would like some feedback on this, then can PR this

[AndrolGenhald]

Sounds good to me, go ahead and PR it and see if any tests fail!

[orklah]

Beware, there is a lot of weirdness going on with stub dependencies.

Due to cache interaction and plugins, it is not clear whether the 'user-defined' part of a stub is defined.