Invalid class-string<T> where T as A|B

[alex-dev]

https://psalm.dev/r/41dd38b32b

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/41dd38b32b

<?php

class A {}
class B {}

/**
 * @template T as A|B
 *
 * @param class-string<T> $_class
 */
function test(string $_class): void {}

Psalm output (using commit f8d1dd8):

ERROR: InvalidDocblock - 9:11 - Invalid templated classname 'A|B' in docblock for test

[orklah]

IIRC, Psalm doesn't support class-string<A|B> so it makes sense templates wouldn't work either like this

[MidnightDesign]

IIRC, Psalm doesn't support class-string<A|B> so it makes sense templates wouldn't work either like this

Maybe this has changed since your comment, but currently it does work.

Also, here's a reproduction case that might be able to prove the usefulness of this feature: Psalm playground link / PHPStan playground link

Edit: changed the links

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/369cccaf3b

<?php

class A {}
class B {}

/**
 * @param class-string<A|B> $_class
 */
function test(string $_class): void {}

Psalm output (using commit 37cc4fd):

No issues!

https://psalm.dev/r/f9eb38c536

<?php

final class Add {}
final class Remove {}
final class Modify {}

class ChangeUtil
{
    /**
     * @template T of Add | Remove | Modify
     * @param iterable<mixed, T> $changes
     * @param class-string<T> $class
     * @return list<T>
     */
	public static function changeByType(iterable $changes, string $class): array
    {
        $filtered = [];
        foreach ($changes as $change) {
            if (!$change instanceof $class) {
                continue;
            }
            $filtered[] = $change;
        }
        return $filtered;
    }
}

Psalm output (using commit 37cc4fd):

ERROR: InvalidDocblock - 12:15 - Invalid templated classname 'Add|Modify|Remove' in docblock for ChangeUtil::changeByType