UnusedFunctionCall on socket* functions

[ghost]

Hello everyone,

I noticed that Psalm complains about my use of socket functions:

for example:
socket_set_block($socket);
results in:
The call to socket_set_block is not used (see https://psalm.dev/206)

Based on the PHP documentation, the functions socket_bind, socket_set_block and socket_set_nonblock, can be used like that when the return code is irrelevant.
https://www.php.net/manual/en/function.socket-set-nonblock.php

Relevant snippet: https://psalm.dev/r/43f28bcd5d

Thank you.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/43f28bcd5d

<?php

$socket = socket_create(AF_UNIX, SOCK_STREAM, 0);

socket_bind($socket, "/run/daemon.sock");

socket_set_nonblock($socket);

socket_set_block($socket);

Psalm output (using commit 14d48a0):

ERROR: UnusedFunctionCall - 5:1 - The call to socket_bind is not used

ERROR: UnusedFunctionCall - 7:1 - The call to socket_set_nonblock is not used

ERROR: UnusedFunctionCall - 9:1 - The call to socket_set_block is not used

[weirdan]

They need to be added to this list:

psalm/src/Psalm/Internal/Codebase/Functions.php

Lines 412 to 423 in a157743

	public function isCallMapFunctionPure(
	Codebase $codebase,
	?NodeTypeProvider $type_provider,
	string $function_id,
	?array $args,
	bool &$must_use = true
	): bool {
	$impure_functions = [
	// file io
	'chdir', 'chgrp', 'chmod', 'chown', 'chroot', 'copy', 'file_get_contents', 'file_put_contents',
	'opendir', 'readdir', 'closedir', 'rewinddir', 'scandir',
	'fopen', 'fread', 'fwrite', 'fclose', 'touch', 'fpassthru', 'fputs', 'fscanf', 'fseek', 'flock',