Object shapes in assertions do not work anymore

[boesing]

Hey there,

I've recently upgrade psalm to v5 in another project where we use object shapes to determine properties from json_decode objects. So we have an assertion method which then should tell psalm that there are properties with specific types.

This does not properly seem to work, at least in my example here:
https://psalm.dev/r/eb1bed0bf9

Is that something which is related to psalm v5 or am I oversee something?

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/eb1bed0bf9

<?php

final class Foo
{
    public const STATUS_OK = 'ok';
    public const STATUS_FAIL = 'fail';
}

$foo = new stdClass();

/** @psalm-assert object{status: Foo::STATUS_*} $bar */
function assertObjectShape(object $bar): void {
}

assertObjectShape($foo);
$status = $foo->status;
/** @psalm-trace $status */

Psalm output (using commit 390da64):

INFO: UnusedParam - 12:35 - Param $bar is never referenced in this method

ERROR: RedundantCondition - 15:1 - Type stdClass for $foo is always object{status:Foo::STATUS_*}

INFO: MixedAssignment - 16:1 - Unable to determine the type that $status is being assigned to

INFO: Trace - 17:28 - $status: mixed

INFO: UnusedVariable - 16:1 - $status is never referenced or the value is not used

[danog]

While this is still technically a bug, I recommend using valinor DTOs, instead.