Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide Upload with a File Object. #80

Closed
nicolastakashi opened this issue Aug 21, 2018 · 2 comments
Closed

Provide Upload with a File Object. #80

nicolastakashi opened this issue Aug 21, 2018 · 2 comments

Comments

@nicolastakashi
Copy link
Contributor

Hi folks!

First of all congratulations for a great job with the Vimeo platform.

Currently, I'm using the Vimeo API to upload some videos from my front-end application using ReactJS.

I had a necessity to provide a JavaScript File Object instead of a file path at the upload function.

I wrote a function to provide this behavior and I get success with my implementation only creating a new function and changed some things.

I want to discuss that if make sense to send a pull request with my implementation.

If you want to check the code before a Pull Request, just click here and look the vimeo.js exists two new functions called:

- uploadFile
- performTusFileUpload
@erunion
Copy link
Contributor

erunion commented Aug 27, 2018

Feel free to pull this into a pull request!

@nicolastakashi nicolastakashi mentioned this issue Aug 28, 2018
Closed
@nicolastakashi nicolastakashi mentioned this issue Oct 21, 2018
Merged
@vycoder vycoder mentioned this issue Nov 8, 2018
Closed
@erunion
Copy link
Contributor

erunion commented Nov 9, 2018

Released to 2.1.1.

@erunion erunion closed this as completed Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erunion @nicolastakashi