Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source files are different in the pypi package than in the repo #76

Closed
aramboi opened this issue Oct 23, 2015 · 2 comments · Fixed by #77
Closed

Source files are different in the pypi package than in the repo #76

aramboi opened this issue Oct 23, 2015 · 2 comments · Fixed by #77
Assignees
@greedo

Comments

@aramboi
Copy link

aramboi commented Oct 23, 2015

Line https://github.com/vimeo/vimeo.py/blob/master/vimeo/client.py#L16 in the package is:

API_ROOT = "http://api.vimeo.dev"

This causes the connections without a full URL path to fail with a 404.

Looks like the source was tested in the dev environment and the URL was not changed back to the production one before being packaged.
@aramboi
Copy link
Author

aramboi commented Oct 23, 2015

Package links with this issue:
https://github.com/vimeo/vimeo.py/releases/download/0.3.1/PyVimeo-0.3.1.tar.gz
https://pypi.python.org/packages/source/P/PyVimeo/PyVimeo-0.3.1.tar.gz

@greedo greedo mentioned this issue Oct 23, 2015
Merged
@aramboi
Copy link
Author

aramboi commented Oct 23, 2015

wow, very fast fix. Thanks. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greedo greedo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Version bump vimeo/vimeo.py
2 participants
@aramboi @greedo