Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Muttator Edit message Insert-Link via "Ctrl-K" is broken #816

Open
vlcinsky opened this issue Dec 10, 2017 · 2 comments
Open

Muttator Edit message Insert-Link via "Ctrl-K" is broken #816

vlcinsky opened this issue Dec 10, 2017 · 2 comments

Comments

@vlcinsky
Copy link

Issue type:
  • Bug report
Version:
Muttator:	1.4 (created: 2017/11/27 01:54:41)
Thunderbird:	Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0```

##### Description:

Edit message, select text and try to add url link to it using Ctrl-K (as whown in Insert-Insert link menu item).

Instead of insert link dialog popping up, it simply replaces the original text and that is all.
##### Expected behavior:
Insert url link dialog shall pop up and allow adding url to add to the selected piece of text.

##### Steps to reproduce:

Create message, visually select some text, use Ctrl-K
@guobin2312
Copy link

I had the same problem, had to add this to muttatorrc to restore original Ctrl-l to insert link (ctrl-k might work):

javascript mappings.addUserMap([modes.INSERT, modes.TEXTAREA], [""], "Insert link", function () { goDoCommand("cmd_link"); })

@vlcinsky
Copy link
Author

Thanks a lot @guobin2312

Modified version (used real mapping value instead of empty string it works for me now with Ctrl-K:

javascript mappings.addUserMap([modes.INSERT, modes.TEXTAREA], ["<C-k>"], "Insert link", function () { goDoCommand("cmd_link"); })

And it is awesome being again able to insert links from clipboard without touching any pointing device.

For me it is resolved now. I wonder I this issue shall be closed or it shall be left for possibly modification of muttator code to deal with Ctrl-K properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants