Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log file containing fewer rows than LogDataRowCount causes an error #3

Closed
koele opened this issue Feb 6, 2018 · 3 comments
Closed

Comments

@koele
Copy link

koele commented Feb 6, 2018

If a log file contains fewer rows (or results in fewer rows after filtering) than the predefined row count
will result in blank rows at the bottom of the logDataTable. During processing those blank rows cause
an error due to missing data.

@vimsh
Copy link
Owner

vimsh commented Feb 6, 2018

sorry, can't read your mind and have no clue what you're talking about...

  1. which tab?
  2. what's the error - is it a pop-up, error in log, or program does process the data?
  3. sample log file that causes problem
  4. how to reproduce (step-by-step)?

@koele
Copy link
Author

koele commented Feb 6, 2018

  1. Load Comp tab, but it likely exists in other tabs as well

  2. Error pop-up, screenshot attached msg_error.jpg
    Note: row should be 51, not 501.
    mafs_error

  3. test_log.zip attached
    test_log.zip

  4. Open MAF Scaling
    Go to Load Comp tab
    Click Load Log and select 'test_log.csv' Click OK, scroll down and note lots of empty lines in the log table
    Paste Current MP Table
    Click GO

Thanks for all your hard work!

@vimsh
Copy link
Owner

vimsh commented Feb 9, 2018

Great, thank you!
Just fyi, the row count when you open tab is 200. your file is 47 lines, so all those extra blank rows are fine.
What was missing is a check for those blank rows (Load/IAT Comp were affected), so I added that check and fixed the line numbering.
Changes will be in the next release shortly, just need to finish up a feature request.

@vimsh vimsh closed this as completed Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants