Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

italics terminfo field varies on different shells/oses #48

Closed
mitchgillin opened this issue Aug 31, 2020 · 6 comments · Fixed by #58
Closed

italics terminfo field varies on different shells/oses #48

mitchgillin opened this issue Aug 31, 2020 · 6 comments · Fixed by #58
Labels
bug Something isn't working

Comments

@mitchgillin
Copy link

See attached error
image

OS: 10.15.6 (19G2021)
Shell: ZSH
Python: 3.8.5

@andrespagella
Copy link

andrespagella commented Aug 31, 2020

Same problem here.

OS: 10.15.6
Shell: ZSH
Python: 3.7.3

@agn-7
Copy link

agn-7 commented Aug 31, 2020

Another problem is here when I ran a README.md by present:

> present README.md            

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/present/markdown.py", line 242, in parse
    Element = eval(element_name)
  File "<string>", line 1, in <module>
NameError: name 'Strong' is not defined

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/bin/present", line 8, in <module>
    sys.exit(cli())
  File "/opt/ros/kinetic/lib/python2.7/dist-packages/click/core.py", line 716, in __call__
    return self.main(*args, **kwargs)
  File "/opt/ros/kinetic/lib/python2.7/dist-packages/click/core.py", line 696, in main
    rv = self.invoke(ctx)
  File "/opt/ros/kinetic/lib/python2.7/dist-packages/click/core.py", line 889, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/opt/ros/kinetic/lib/python2.7/dist-packages/click/core.py", line 534, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/present/cli.py", line 18, in cli
    slides = markdown.parse(f.read())
  File "/usr/local/lib/python3.6/dist-packages/present/markdown.py", line 245, in parse
    f"(Slide {sliden + 1}) {element_name} is not supported"
ValueError: (Slide 2) Strong is not supported

OS: Ubuntu 16.04
Shell: zsh
Python 3.6

@vinayak-mehta vinayak-mehta added the bug Something isn't working label Aug 31, 2020
@vinayak-mehta
Copy link
Owner

@mitchgillin Thanks for reporting this! Looks like italics support varies on different shells, I'll look into this.

@agn-7 It should work for you if you're on Python 3.7+ and have present 0.5.0.

@vinayak-mehta vinayak-mehta changed the title Cannot open markdown files italics terminfo field varies on different shells Aug 31, 2020
@vinayak-mehta vinayak-mehta changed the title italics terminfo field varies on different shells italics terminfo field varies on different shells/oses Aug 31, 2020
@vinayak-mehta
Copy link
Owner

This should be fixed with present v0.5.1, please reopen it if you still face the issue.

@mitchgillin
Copy link
Author

Fixed for me! Thanks; can't wait to use it!

@vinayak-mehta
Copy link
Owner

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants