Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON file for adding playlists. #78

Open
utkarsh1311 opened this issue Oct 6, 2022 · 4 comments
Open

Add JSON file for adding playlists. #78

utkarsh1311 opened this issue Oct 6, 2022 · 4 comments

Comments

@utkarsh1311
Copy link

Reason/Context

Please try answering few of those questions

  • Why we need this improvement?

Currently, each playlist is added manually by users by directly editing the index.html file.
This can cause bugs as they can miss certain attributes for the html tags used to render the playlist.
Every playlist card has the same UI. The only things that are changing is the data specific to the user.

  • How will this change help?

If we have a json file in which users can add their personal data, then it will greatly reduce the chances for mistakes in the index.html file. It will also be easier to update and maintain user data. They can easily change their data without affecting the original webpage.

  • What is the motivation?

Currently the index.html file has a lot of duplicated code used to display the various playlists. This can be reduced by adding a json file to manage user data.

Description

Please try answering few of those questions

  • What changes have to be introduced?
    Addition of a JSON file to keep important info about the users.
    Changes to the index.js file to create the playlist card dynamically and add it to the index.html file.
  • Will this be a breaking change?
    No
  • How could it be implemented/designed?
    Add a JSON file and use document.innerHTML properties to dynamically generate playlist cards.

I would like to work on this if this issue is accepted. Please assign it to me.

@utkarsh1311 utkarsh1311 added the enhancement New feature or request label Oct 6, 2022
@vinayakgavariya
Copy link
Owner

@utkarsh1311 go ahead

@utkarsh1311
Copy link
Author

Working on it.

@futoid
Copy link
Contributor

futoid commented Oct 12, 2022

Hi @utkarsh1311 Are you still working in this enhancement?

@utkarsh1311
Copy link
Author

Hey @futoid. Yes, I am working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants