Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Style Guidelines #9

Closed
VenomVendor opened this issue Jun 27, 2015 · 9 comments
Closed

Code Style Guidelines #9

VenomVendor opened this issue Jun 27, 2015 · 9 comments

Comments

@VenomVendor
Copy link
Contributor

Strictly follow Code Style Guidelines for further contribution.

@vinaygaba
Copy link
Owner

I certainly have formatting and cleaning the code on my agenda for the forthcoming release. Thank you for the link. Will strictly enforce it :)

@vinaygaba
Copy link
Owner

Hi @VenomVendor,
I have tried to enforce the suggestions and have formatted some of the code. Would appreciate if you could take a look and point out additional recommendations if any :) Appreciate your contribution. Thank you!

@VenomVendor
Copy link
Contributor Author

@vinaygaba
Copy link
Owner

Hi @VenomVendor,
This is excellent! I have learnt so many new things by just analyzing the formatting you did! I just had one question, which is if you are able to see the layout correctly in the activity_main file of the sample project? I am getting some new errors in the preview screen. Wanted to know if you were seeing the same thing.

@VenomVendor
Copy link
Contributor Author

Yes, I tested against sample project.
Can you tell what exactly is the error?

@vinaygaba
Copy link
Owner

Nevermind, looks like a bug in Android Studio. Restart, Build, Clean seems to have solved it!

@vinaygaba
Copy link
Owner

It was an error in the layout preview screen, on the lines of cannot resolve resource and pointing to the layout inflater line.

@vinaygaba
Copy link
Owner

Yes doing just that. In a minute :)

@vinaygaba
Copy link
Owner

Accepted your pull request and closing this issue. Really appreciate your contribution! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants