Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in Bower.json it is setting the bath to src instead of dist #13

Closed
bdairy opened this issue Apr 25, 2016 · 1 comment
Closed

in Bower.json it is setting the bath to src instead of dist #13

bdairy opened this issue Apr 25, 2016 · 1 comment

Comments

@bdairy
Copy link

bdairy commented Apr 25, 2016

Hi there..

the library was working fine till I think you made an update that causes two issues. the first one,, I couldn't get the file to be added to my index.html.. and when I checked . the folders are under dist,, while in bower.json is says the the main file is under "main": "src/ngMeta.js",... when I changed the src to dist it worked.

Second thing is that you are now reserving the title and title suffex to the function setTitle. why? that caused my whole website not setting titles since I am using setTag('title','..');... I hope that you can do a quick fix for it. thanks

@vinaygopinath
Copy link
Owner

vinaygopinath commented Apr 25, 2016

Sorry about that. It looks like I excluded the src directory from the Bower release but didn't change the main path to dist. This is now fixed in v0.3.9

setTitle checks whether the titleSuffix must be appended to the title, and this is not possible with setTag. As seen in the dynamic meta tags examples, reserving the title and titleSuffix tags for use with the setTitle function enables overriding a default titleSuffix with a custom titleSuffix at runtime, and other useful behaviour. Please replace the setTag function with setTitle for title and titleSuffix, or (not recommended) use v0.3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants