-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working with Webpack #27
Comments
@vinaygopinath can you check this please? we are hoping to use this in prod asap. Thanks McGilly |
It would require a simple modification in the ngMeta.js. Just need to return the |
The change in PR #28 seems inconsistent with the way I'm used to exporting a module. I think we should return the name property. Not sure about the rest of you. return angular.module('ngMeta', [])
.provider('ngMeta', function() {
...
})
.name // <-- return the name Without returning the name, I need to import angular from 'angular'
import 'ng-meta'
export const AppModule = angular
.module('app', [
'ngMeta'
])
.name And I would like to: import angular from 'angular'
import ngMeta from 'ng-meta'
export const AppModule = angular
.module('app', [
ngMeta
])
.name |
@devotis Thanks for the suggestion. I'm open for the module to return the name as long as it has no impact on the way the module is imported in other build systems. Would you be willing to test it out with webpack, and, say, gulp and make a new PR? |
I tried using this with Webpack (using require and import) however i couldn't get it to work.
By making the following change:
It worked in webpack.
The text was updated successfully, but these errors were encountered: