This repository has been archived by the owner on Jan 27, 2023. It is now read-only.
Reset the state of matrix object using a proper reset method. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Matrix method 'set(null)', with null parameter, works fine on emulators and real devices, but doesn't play well in unit tests with Robolectric, which throw an Exception after checking for null params. Since a proper method for reseting the state of Matrixes are available, should not be an issue using it.
|
The changes look good, will do some testing to double check and merge and make a release when I get a chance, but you should report this upstream to robolectric as well! |
|
Nice, man! Thanks for that! |
vinc3m1
added a commit
that referenced
this pull request
Oct 18, 2014
Reset the state of matrix object using a proper reset method.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library is pretty awesome, I'm really happy with that! :)
Currently I'm having an issue when trying to run Robolectric tests that inflates layouts containing a RoundedImageView:
Since android.graphics.Matrix.set(param) does a null check, and calls android.graphics.Matrix.reset() when the param is null - see android.graphics.Matrix code, line 260, it might not be a problem to directly call the reset instead of set(null). This would keep everything working as before, and would make Robolectric happy! =]