Skip to content
This repository has been archived by the owner on Jan 27, 2023. It is now read-only.

Support for Volley? #63

Closed
townsfolk opened this issue Oct 22, 2014 · 8 comments
Closed

Support for Volley? #63

townsfolk opened this issue Oct 22, 2014 · 8 comments

Comments

@townsfolk
Copy link

First off, thank you very much for putting this into a maven-ized library.

With the official Android documentation mentioning volley (maybe even recommending it), and the open bug for fixing setImageUri, is there any possibility to add support for Volley? Or do you have any advice on using Volley to download and manage the bitmaps for the rounded image view? Perhaps a way to delegate bitmap retrieval and view re-use to Volley's NetworkImageView?

Thanks for any help.

@vinc3m1
Copy link
Owner

vinc3m1 commented Nov 23, 2014

Interesting and definitely a possibility. I'm not familiar enough with volley, nor have the time to look into it right now, but pull requests are welcome!

@ameen-sarsour
Copy link

Hi,
I've create a class make rounded image, it's extend from NetworkImageView, please check it
https://gist.github.com/ameen-sarsour/5fecb7052eaa719d330b

@ongakuer
Copy link

I've created another one which extend from RoundedImageView
https://gist.github.com/ongakuer/3df480c28540b4eb779d

@vinc3m1
Copy link
Owner

vinc3m1 commented Feb 27, 2015

@ameen-sarsour your solution is definitely not very viable since you're creating an extra bitmap (double memory use) and not re-using any code from this library, mostly RoundedDrawable.

@ongakuer this looks feasible, if you want to open a pull request we can definitely try it out.

@ongakuer
Copy link

@vinc3m1
It's not necessary to open a pull request. It depends on Volley.

@vinc3m1
Copy link
Owner

vinc3m1 commented Mar 3, 2015

Since it's a separate class, it woudln't hurt to include volley as a provided dependency so people can use it if they'd like.

@ongakuer
Copy link

ongakuer commented Mar 4, 2015

@vinc3m1
But there is no official Maven repo for Volley

@vinc3m1
Copy link
Owner

vinc3m1 commented Mar 5, 2015

True... I'll mark this closed then and people can reference gists.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants