Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quitting Clippi prematurely should restore OBS filename format #49

Closed
vinceau opened this issue Apr 16, 2020 · 1 comment
Closed

Quitting Clippi prematurely should restore OBS filename format #49

vinceau opened this issue Apr 16, 2020 · 1 comment
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@vinceau
Copy link
Owner

vinceau commented Apr 16, 2020

If recording is in progress and Clippi is closed, the OBS filename format is not restored, likewise if the program is force quit or if it crashed.

We should add a hook which detects when the Electron app is about to be closed/quit and send a message to OBS to restore the filename.

This method won't be able to handle crashes or force quits however. We could restore the most recently backed up filename format on first boot, however that is not guaranteed to be up to date and the user may have changed it between now and the last time they ran Clippi.

@vinceau vinceau added the enhancement New feature or request label May 18, 2020
@vinceau vinceau added the wontfix This will not be worked on label Dec 17, 2020
@vinceau
Copy link
Owner Author

vinceau commented Dec 17, 2020

Closing this as won't fix. Setting the OBS filename is too finicky in general. Instead we just add a warning that this is an experimental feature and that users should use it at own risk. Added the option and the warning in 3356bc2.

@vinceau vinceau closed this as completed Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant