Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button combination time throttle doesn't work as expected #74

Closed
vinceau opened this issue Jun 2, 2020 · 0 comments · Fixed by #75
Closed

Button combination time throttle doesn't work as expected #74

vinceau opened this issue Jun 2, 2020 · 0 comments · Fixed by #75
Labels
bug Something isn't working

Comments

@vinceau
Copy link
Owner

vinceau commented Jun 2, 2020

Currently when processing replays for button combinations, we are using throttleTime to filter out consecutive presses. This is actually incorrect since processing a file can often take less than a second, so if we throttle for say 5 seconds, we won't pick up any combos past the first one.

@vinceau vinceau added the bug Something isn't working label Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant