Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving to trash is broken on Windows #78

Closed
vinceau opened this issue Jun 15, 2020 · 1 comment · Fixed by #79
Closed

Moving to trash is broken on Windows #78

vinceau opened this issue Jun 15, 2020 · 1 comment · Fixed by #79
Labels
bug Something isn't working

Comments

@vinceau
Copy link
Owner

vinceau commented Jun 15, 2020

According to this tweet there's an issue with the current method of using trash to move to the Recycle bin.

Also it appears that we don't need to rely on an external library for such functionality as it's built into Electron.
@vinceau vinceau self-assigned this Jun 15, 2020
@vinceau vinceau added the bug Something isn't working label Jun 15, 2020
@vinceau vinceau mentioned this issue Jun 16, 2020
Merged
@vinceau
Copy link
Owner Author

vinceau commented Jun 16, 2020

Fixed in #80.

@vinceau vinceau closed this as completed Jun 16, 2020
@vinceau vinceau removed their assignment Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix moving to trash in Windows vinceau/project-clippi
1 participant
@vinceau