Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ask to overwrite combos.json #81

Closed
Savestate2A03 opened this issue Jun 16, 2020 · 3 comments · Fixed by #83
Closed

Ask to overwrite combos.json #81

Savestate2A03 opened this issue Jun 16, 2020 · 3 comments · Fixed by #83
Labels
enhancement New feature or request

Comments

@Savestate2A03
Copy link

Savestate2A03 commented Jun 16, 2020 •
edited
Loading

Hey, just spent about 30 minutes letting it go through a number of slippi files, and accidentally clicked "Process Highlights" again after it finished processing. Without a prompt, the combos file was overwritten and I had lost the data from the run.

A prompt to overwrite would likely be helpful here, thank you!
@vinceau vinceau added the enhancement New feature or request label Jun 16, 2020
@vinceau
Copy link
Owner

vinceau commented Jun 16, 2020

Thanks for the suggestion. Will consider it for the next release. :)

@vinceau vinceau mentioned this issue Jun 16, 2020
Merged
@vinceau
Copy link
Owner

vinceau commented Jun 16, 2020

Fixed in #80.

@vinceau vinceau closed this as completed Jun 16, 2020
@Savestate2A03
Copy link
Author

And with great speed ! Much appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ask for confirmation when overwriting JSON file vinceau/project-clippi
2 participants
@vinceau @Savestate2A03