Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong contrast for some icons #16

Closed
prettyv opened this issue Feb 16, 2022 · 5 comments
Closed

Wrong contrast for some icons #16

prettyv opened this issue Feb 16, 2022 · 5 comments

Comments

@prettyv
Copy link

prettyv commented Feb 16, 2022

Since commit e886872 there are some icons that now have wrong (I guess fill) colors:

Screenshot_20220216_110200
@vinceliuice
Copy link
Owner

I'll fix this

@vinceliuice
Copy link
Owner

Fixed!

@prettyv
Copy link
Author

prettyv commented Feb 16, 2022

Looking good, thanks!

@vinceliuice
Copy link
Owner

You are welcome!

@prettyv
Copy link
Author

prettyv commented Apr 8, 2022

@vinceliuice I found another issue of the same kind, this time it's the active state of the bluetooth indicator. More precisely icons 22-22-preferences-system-bluetooth-activated and 16-16-preferences-system-bluetooth-activated are missing the ColorScheme-Text class. I'd submit a PR, but I don't really have a proper SVG workflow besides editing the XML representation directly, so I thought I'd rather write first. If that would be generally sufficient for you I'll see if I can do that in the future.

Screenshot_20220408_202026

@nBalykin nBalykin mentioned this issue Jul 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prettyv @vinceliuice