history writing on exit without ipython broken

[juliantaylor]

readline is imported lazily in 0.5.1 causing write_history_file to fail due to the undefined readline variable.
the variable must be declared global for it to work:

    except ImportError:
        global readline
        readline = None

This only happens when ipython is not installed.

# snimpy 
Snimpy (0.5.1) -- An interactive SNMP tool.
  load        -> load an additional MIB
  M           -> manager object
[snimpy]> exit()
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File "/usr/lib/python2.7/atexit.py", line 24, in _run_exitfuncs
    func(*targs, **kargs)
  File "/usr/lib/python2.7/dist-packages/snimpy/main.py", line 47, in write_history_file
    if readline and conf.histfile:
NameError: global name 'readline' is not defined
Error in sys.exitfunc:
Traceback (most recent call last):
  File "/usr/lib/python2.7/atexit.py", line 24, in _run_exitfuncs
    func(*targs, **kargs)
  File "/usr/lib/python2.7/dist-packages/snimpy/main.py", line 47, in write_history_file
    if readline and conf.histfile:
NameError: global name 'readline' is not defined

[juliantaylor]

with this fix you now get this when you don't have a config file:

Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File "/usr/lib/python2.6/atexit.py", line 24, in _run_exitfuncs
    func(*targs, **kargs)
  File "/usr/local/lib/python2.6/dist-packages/snimpy/main.py", line 111, in <lambda>
    os.path.expanduser(conf.histfile)))
IOError: [Errno 2] No such file or directory
Error in sys.exitfunc:
Traceback (most recent call last):
  File "/usr/lib/python2.6/atexit.py", line 24, in _run_exitfuncs
    func(*targs, **kargs)
  File "/usr/local/lib/python2.6/dist-packages/snimpy/main.py", line 111, in <lambda>
    os.path.expanduser(conf.histfile)))
IOError: [Errno 2] No such file or directory

a better error message would be nice

[vincentbernat]

Even without a configuration file, you should get your history written in ~/.snimpy_history. I don't understand why you get such a message. Maybe you have a configuration file that asks to write history into an inexistant directory?

[juliantaylor]

sorry, that is what happened. I forgot to set my HOME folder correctly when testing in a chroot.
It works fine, thanks

[vincentbernat]

Great to know!