Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restored support for apks as default arguments #45

Conversation

Ayowel
Copy link

@Ayowel Ayowel commented Mar 5, 2018

Hi,

If a path is given as argument without the -p option, it is not recognised. This PR restores support for calls such as python3 stacoan.py yourApp.apk while still enabling the launch of a server by default.

This should not affect the server, however I can't test it at the moment (Address already in use error when I try to use the server, with or without this modification, even after a reboot).

@vincentcox
Copy link
Owner

Will look at the PR's when I am at home. Really, thank you 👍 for the feedback and effort put in this project. I think I will add you to the top contributor's list soon.
About the address already in use: did you get that with the executables (from the releases)? Or did you get it when running the python source code?

@Ayowel
Copy link
Author

Ayowel commented Mar 5, 2018

Happens when running python3 stacoan.py in a Kali VM from the repository's code.

On a side note, I saw you talk about your inability to use Docker as you have VMWare installed. I am in the same situation and use docker by running it from a fedora VM ; you might want to look into this.

@vincentcox
Copy link
Owner

Did you tried to drag and drop an apk on it? It seems that the arguments are causing some trouble

@Ayowel
Copy link
Author

Ayowel commented Mar 5, 2018

No, as I said I can't seem to get the web interface to work no matter what I do. I'll look into it tomorrow and find a way to fix this.

@vincentcox
Copy link
Owner

I made some changes in the develop branch. Now you are able to choose both the ports in the configuration file. Maybe try a different port and see if that resolves your problem.
I tested it on several devices and I cannot seem to reproduce the issue.
As again, really thanks for your effort! I will put you in the readme file. Shall I link your twitter or github account?

@vincentcox
Copy link
Owner

The project evolved a bit since this pull request was started. I think that the drag and drop interface is great to work without parameters. Dropping the -p tag brought up some more problems along the way so I think I just keep it that way if people want to use the command line. However, I really appreciate your contribution and suggestion.

@vincentcox vincentcox closed this Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants