-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add leading "0:" to output involving sub-minute times? #19
Comments
Thanks for suggestion. I prefer the shorter format, but this is subjective and it's easy to add another format (there's already an option to display durations as seconds). Would you like to try writing a PR for this ? It's an easy one, even if you never wrote any Rust before. There are 3 steps:
|
Thanks for being open to this! Sure, happy to try to put together a PR. :-) i've cloned the repo, and tried running
Is this something that should be addressed before proceeding further? Would you like the backtrace? |
I've extracted those test failures into their own issues, let's handle them individually. Bugfixes are more important than new features, but feel free to focus on the issues that interest you. |
All tests now passing, thanks! Will start working on the PR. :-) |
Firstly, thanks for emlop!
This just a small thing: i find times like a bare "45" for "45 seconds" to be disorienting, as from other contexts i'm used to sub-minute times being represented as e.g. "0:45" or "0:0:45". (And in those contexts, a bare "45" is used to mean "45 minutes" or "45 hours".)
Might you be willing to change the output format accordingly, or make this an option? (Unless this option already available, and i've missed it ....)
The text was updated successfully, but these errors were encountered: