Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions about eq(3), eq (8) and eq(12) in the paper #5

Closed
emjay73 opened this issue Oct 12, 2021 · 2 comments
Closed

Questions about eq(3), eq (8) and eq(12) in the paper #5

emjay73 opened this issue Oct 12, 2021 · 2 comments

Comments

@emjay73
Copy link

emjay73 commented Oct 12, 2021

I have some questions about the equations in the paper.
I think those equations should be corrected.
If I misunderstood something, please let me know.

(3)
in the paper
image

expected
image

(8) Parenthesis position is somewhat weird.
in the paper
image
expected
image

(12) Scale factor defined in MPI and MINE is in a reverse relationship, but equations do not reflect the difference.
in the paper
image
expected
image

@emjay73 emjay73 changed the title Questions about eq (8) and eq(12) in the paper Questions about eq(3), eq (8) and eq(12) in the paper Oct 12, 2021
@lijx10
Copy link
Collaborator

lijx10 commented Oct 13, 2021

Eq. 3

d_i = 1 / z_i. z_n is the nearest plane depth with smallest value, while z_f is the farthest plane depth with the largest value. Therefore, d_n > d_f. In Eq. 3, (d_f - d_n) < 0. So the equation is correct.

Eq. 8

You are correct, there is a redundent left parentheses on Z_src(x,y). Thanks for pointing it out. We will update our arxiv paper.

Eq. 12

You are correct, the predicted disparity D_src / D_tgt should be multiplied by scale s.

Thanks a lot for pointing out the errors in the paper.

@emjay73
Copy link
Author

emjay73 commented Oct 13, 2021

Oh yeah, about eq 3, I confused near/far notation with z, not disparity.
Thanks! Things get clear for me.

@emjay73 emjay73 closed this as completed Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants