Sni late checks #147
Merged
Sni late checks #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to create list of supported ciphers after whe have answer srom SNI
|
Thanks ! that's useful, not sure if there's any way to detect an insufficient configuration that lead to a server not allowing any connection thought.. |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to create list of supported ciphers after we have answer from SNI hook.
Technically SNI is always called so if our callback supports
Nothingwe cover all cases and, really not need the main certificate.It is possible that additional credentials will support different ciphers than the main one so we need to retest it after we know which ciphers we actually have.