Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the HasBackend(..) class fully, so that developers can use TLS over their own channels. #149

Merged
merged 1 commit into from
Jul 30, 2016

Conversation

acw
Copy link
Contributor

@acw acw commented May 23, 2016

No description provided.

@acw
Copy link
Contributor Author

acw commented May 23, 2016

Don't merge this quite yet, there's a flaw in my plan.

@acw
Copy link
Contributor Author

acw commented Jul 10, 2016

Hi! Just checked this over and it seems to work. I've also rebased it to the most recent commit, so it should merge nice and cleanly.

The key benefit of this work, as stated, is that developers can develop their own TLS backends without requiring you to add flags. If it's a bother, you could probably remove the HaNS flag if you wanted, and we could create the instance elsewhere. For me, this let me create a completely fake network stack that I can use in testing the Tor client. (If that would seem useful to you, I can pull it out as a separate library. It would let you make monadic QuickCheck tests of TLS handshakes without network access.)

Thanks! And thanks again for the library. If there's anything else I can do to clean up this patch, please tell me.

@vincenthz vincenthz merged commit 76e6a37 into haskell-tls:master Jul 30, 2016
@vincenthz
Copy link
Collaborator

sure, that doesn't look like it would cause problems, and I can see the usefulness. Thanks !

@erikd
Copy link
Contributor

erikd commented Aug 28, 2016

@vincenthz, hi! Any chance we could get a new release with this PR included? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants