New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ClientConfig module #162
Closed
debug-ito
wants to merge
20
commits into
haskell-tls:master
from
debug-ito:simple_clientparam_config_rebase20160925
Closed
Add ClientConfig module #162
debug-ito
wants to merge
20
commits into
haskell-tls:master
from
debug-ito:simple_clientparam_config_rebase20160925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce for Bytes, because even the type constructor is hidden.
it has no CA certificates or supported ciphers.
we use HashSHA256 because validateDefault uses it.
I would like to close this issue because this is out-dated. I would like to suggest to create a new package to contain useful modules. |
Thanks for reply. I'm so sad that this pull-request could not attract almost no attention, but I understand it. Even I forgot making this p-r. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a new module
Network.TLS.ClientConfig
, which helps users configure their client-side TLS settings.I think
Network.TLS
module is too difficult for some users. Even a simple customization (such as adding a CA certificate toClientParams
) requires traversing its nested structures, looking for the right field to modify, consulting other modules and importing necessary symbols from them. This is so time consuming.Network.TLS.ClientConfig
module is the one-stop module to configureClientParams
. It defines some setter functions for fields that I think many users want to customize. It also re-exports data types from other modules, so users don't need to import them one by one.