Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defining Finite Field Diffie-Hellman Ephemeral Parameters in RFC 7919. #174

Merged
merged 1 commit into from
Dec 28, 2016
Merged

defining Finite Field Diffie-Hellman Ephemeral Parameters in RFC 7919. #174

merged 1 commit into from
Dec 28, 2016

Conversation

kazu-yamamoto
Copy link
Collaborator

My concerns:

  • Am I correctly understand what params_bits is?
  • Is this module path a right place?
  • It is OK to get tests slower?

Relating to #94.

@kazu-yamamoto
Copy link
Collaborator Author

What is a show stopper for this PR?

vincenthz
vincenthz approved these changes Dec 28, 2016
View reviewed changes
Copy link
Collaborator

@vincenthz vincenthz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking fine, 2 comments though:

  • not sure if the order of the parameters sizes are relevant, but we start with the smallest (2048 bits) instead of the contrary (or something in the middle maybe e.g. 4096 bits).
  • indent is 4 and personally prefer the { when starting a new record value to start on the same line as the ,.

@vincenthz vincenthz merged commit 78edeef into haskell-tls:master Dec 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincenthz vincenthz vincenthz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kazu-yamamoto @vincenthz