Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding the warnig and deprecated pragmas for ciphersuite. #222

Merged
merged 2 commits into from
Apr 28, 2017
Merged

adding the warnig and deprecated pragmas for ciphersuite. #222

merged 2 commits into from
Apr 28, 2017

Conversation

kazu-yamamoto
Copy link
Collaborator

This is the first step for #153.

@ocheron
Copy link
Contributor

ocheron commented Apr 27, 2017

👍 for not deprecating ciphersuite_all that has its use.

I think we should remove ciphersuite_medium from tls-debug in that same PR.

@kazu-yamamoto
Copy link
Collaborator Author

Done.

ocheron
ocheron approved these changes Apr 28, 2017
View reviewed changes
Copy link
Contributor

@ocheron ocheron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After merging I think it deserves an entry in the CHANGELOG.
And also better emphasis of ciphersuite_default in existing entry about sha384 ciphers.

kazu-yamamoto added a commit to kazu-yamamoto/hs-tls that referenced this pull request Apr 28, 2017
@kazu-yamamoto
Merge PR haskell-tls#222.
0caa507
@kazu-yamamoto kazu-yamamoto merged commit cc917a7 into haskell-tls:master Apr 28, 2017
@kazu-yamamoto
Copy link
Collaborator Author

After merging I think it deserves an entry in the CHANGELOG.

Done.

@kazu-yamamoto
Copy link
Collaborator Author

And also better emphasis of ciphersuite_default in existing entry about sha384 ciphers.

I don't understand this. Would you resolve it by yourself?

@ocheron
Copy link
Contributor

ocheron commented Apr 29, 2017

Done in e368369.

@kazu-yamamoto kazu-yamamoto deleted the deprecate branch April 30, 2017 12:01
@kazu-yamamoto
Copy link
Collaborator Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocheron ocheron ocheron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kazu-yamamoto @ocheron