-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Bytes to ByteString #230
Conversation
0790e04
to
8e17544
Compare
|
1ce9935
to
f97e95c
Compare
`Bytes` was a type alias for `ByteString`. The `Bytes` type is kept because it is exposed in the API. Have built http-client-tls and warp-tls from Hackage with this version of tls and zero changes were needed.
Ping? |
There is still the question to deprecate or simply remove the type alias. |
The code in this PR will not cause any difficulty at all in client code. No compile errors, no warnings, no changes in behavior. I would therefore advise against deprecating the |
Since what is on master already has breaking changes, I'd be happy to remove the |
We should ping @vincenthz. |
I think we can't be wrong deprecating the type alias (and possibly moving the definition to Network.TLS itself). If it's used out of tls, it's probably by accident. |
@ocheron I added a commit to do as you suggested. |
Though @vincenthz does not respond, I would like to merge this PR. |
Bytes
was a type alias forByteString
. TheBytes
type is keptbecause it is exposed in the API.
Have built http-client-tls and warp-tls from Hackage with this
version of tls and zero changes were needed in those packages.
Related to #229 . I have no problem whatsoever moving from
Bytes
/ByteString
toByteArray
but whileBytes
andByteString
are the same,Bytes
should be replaced withByteString
if it can be done without breaking the API (and it can).