One way key update

[kazu-yamamoto]

This should fix #311.

[ocheron]

OK but I still think it would be good to add an argument to updateKey and let QuickCheck test one-way update too.

[kazu-yamamoto]

Done. But would you check runTLSPipeSimpleKeyUpdate? I don't know how to write the test case smartly in this case.

[ocheron]

With QuickCheck the canonical way is to put Arbitrary instances as parameters to the properties, so that generated values are displayed in case of test failure.

prop_handshake_keyupdate :: KeyUpdateRequest -> KeyUpdateRequest -> Property
prop_handshake_keyupdate reqClient reqServer = monadicIO $ do
    params <- pick arbitraryPairParams
    let possible = isVersionEnabled TLS13 params
    runTLSPipeN 3 params (tlsServer possible) (tlsClient possible)
  where tlsServer possible ctx queue = do
            handshake ctx
            d0 <- recvDataNonNull ctx
            sent <- updateKey ctx reqServer
            possible `assertEq` sent
            d1 <- recvDataNonNull ctx
            d2 <- recvDataNonNull ctx
            writeChan queue [d0,d1,d2]
        tlsClient possible queue ctx = do
            handshake ctx
            d0 <- readChan queue
            sendData ctx (L.fromChunks [d0])
            d1 <- readChan queue
            sendData ctx (L.fromChunks [d1])
            sent <- updateKey ctx reqClient
            possible `assertEq` sent
            d2 <- readChan queue
            sendData ctx (L.fromChunks [d2])
            bye ctx

But we don't use monadicIO like this right now. Something like 549eb76 will be good enough (updating tls-debug too).

[kazu-yamamoto]

@ocheron Thank you for your explanation.

tls-debug: done.

Ready for merging?

[kazu-yamamoto]

I will merget this. Please register another issue if necessary.

[kazu-yamamoto]

Merged.
Thank you for your review.