Some thread-safety for writes #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calls to sendPacket/sendPacket13 are protected by the write lock to make sure we never try to send two packets simultaneously. In recvData, the use of the read lock is extended to the actual processing of the packet just received. This prevents another packet to slip in before the full response is completed.
Merges processing of UpdateNotRequested and UpdateRequested together. The latter has just a few more calls.
The library exposes things like ciphersuite_default, so we can assume the underscore syntax is acceptable for the whole project.
The list of pending actions is always used with external synchronization to make sure the actions are processed in the order received. So locking the list itself is not necessary.
Like all functions exposed by this module.
kazu-yamamoto
approved these changes
Dec 18, 2018
kazu-yamamoto
added a commit
to kazu-yamamoto/hs-tls
that referenced
this pull request
Dec 18, 2018
|
Merged. |
|
Thanks for your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes the use of read lock / write lock to handle concurrent calls sending and receiving data.
Hopefully it will be enough to solve the issue raised in #323.