Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to documentation and cipher suites #340

Merged
merged 3 commits into from
Jan 21, 2019
Merged

Improvements to documentation and cipher suites #340

merged 3 commits into from
Jan 21, 2019

Conversation

ocheron
Copy link
Contributor

@ocheron ocheron commented Jan 20, 2019

No description provided.

sharedCredentials :: Credentials
-- | Callbacks used by clients and servers in order to resume TLS
-- sessions. The default implementation never resumes sessions. Package
-- <https://hackage.haskell.org/package/tls-session-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a broken markup due to folding. I will fix this.

@kazu-yamamoto kazu-yamamoto self-requested a review January 21, 2019 03:25
Copy link
Collaborator

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

kazu-yamamoto added a commit to kazu-yamamoto/hs-tls that referenced this pull request Jan 21, 2019
@kazu-yamamoto kazu-yamamoto merged commit 0b98247 into haskell-tls:master Jan 21, 2019
@kazu-yamamoto
Copy link
Collaborator

Merged.

@ocheron ocheron deleted the doc-ciphersuites branch January 21, 2019 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants