Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order of signature schemes #353

Closed
wants to merge 1 commit into from
Closed

Order of signature schemes #353

wants to merge 1 commit into from

Conversation

ocheron
Copy link
Contributor

@ocheron ocheron commented Jan 29, 2019

From the discussion in #194 we can have the following default:

  • new EdDSA first
  • ECDSA preferred to RSA (because we have same in ciphersuites)
  • hash order for ECDSA follows elliptic curve performance
  • our traditional hash order for RSA

I understand SHA-384 is not absolutely necessary with RSA, but we can keep it for completeness.

@kazu-yamamoto kazu-yamamoto self-requested a review January 30, 2019 00:56
kazu-yamamoto
kazu-yamamoto approved these changes Jan 30, 2019
View reviewed changes
Copy link
Collaborator

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kazu-yamamoto added a commit to kazu-yamamoto/hs-tls that referenced this pull request Jan 30, 2019
@kazu-yamamoto
Merge PR haskell-tls#353
b292724
@kazu-yamamoto
Copy link
Collaborator

Merged.

@ocheron ocheron deleted the signature-schemes branch February 3, 2019 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazu-yamamoto kazu-yamamoto kazu-yamamoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ocheron @kazu-yamamoto