Send "certificate_authorities" extension #372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds requirement from RFC 8446 section 4.4.2.4: If the server supplies an empty Certificate message, the client MUST abort the handshake with a "decode_error" alert. This can apply before TLS 1.3 too because the public key is needed for key exchange, and it then avoids the EmptyChain validation failure which currently exists.
It's necessary to correctly send the alert to the peer.
|
This looks good to me. But I have one question. What about |
|
I don't have plan for client hello, there is no existing API this would be useful to. |
kazu-yamamoto
added a commit
to kazu-yamamoto/hs-tls
that referenced
this pull request
Jul 9, 2019
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main point here is to add "certificate_authorities" extension currently missing in TLS13 certificate requests so that we keep same capabilities than with lower versions. Unfortunetly I did not see earlier that the extension was missing so I had to change to a bit more complex design to send post-handshake requests.
The PR also allows to send CertificateRequired alerts to the client and adds a few checks.