Do not use pending actions without 0-RTT #380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pending actions now always call processHandshake13 before executing the action, but may use the preceding transcript hash when it is required. This removes the need for a postAction. The recv state machine is modified accordingly with function recvHandshake13hash.
kazu-yamamoto
approved these changes
Jul 16, 2019
kazu-yamamoto
added a commit
to kazu-yamamoto/hs-tls
that referenced
this pull request
Jul 16, 2019
|
Merged. |
|
This is not necessarily the end of the story. For #355 I've been playing with an encoding of pending actions as a parsing transformer sink. data PendingActionStep a
= PendingActionRecv (Handshake13 -> PendingAction a)
-- ^ simple pending action
| PendingActionHash (ByteString -> Handshake13 -> PendingAction a)
-- ^ pending action taking transcript hash up to preceding message
| PendingActionDone a
-- ^ no action is pending
newtype PendingAction a = PendingAction
{ runPendingAction :: IO (PendingActionStep a)
}With something like this I think it's possible to have the exact same monadic code run through |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #355: the PR changes the server implementation to wait for client Finished unless early data is sent and accepted. So the transition to TLS13 does not raise any security concern by default. Later a server parameter could be added to relax the constraint and get the previous behavior.
I include a refactoring of pending actions and RecvHandshake13M. A common pattern is actions needing the transcript hash up to the previous handshake message. The infrastructure can provide this service, and there is no need for postAction anymore.