Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify position of "pre_shared_key" extension #382

Closed
wants to merge 1 commit into from
Closed

Verify position of "pre_shared_key" extension #382

wants to merge 1 commit into from

Conversation

ocheron
Copy link
Contributor

@ocheron ocheron commented Jul 14, 2019

Adds the requirement from RFC 8446 section 4.2.11:

Servers MUST check that it is the last extension and otherwise fail
the handshake with an "illegal_parameter" alert.

Adds the requirement from RFC 8446 section 4.2.11:

   Servers MUST check that it is the last extension and otherwise fail
   the handshake with an "illegal_parameter" alert.
Copy link
Collaborator

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kazu-yamamoto added a commit to kazu-yamamoto/hs-tls that referenced this pull request Jul 16, 2019
@kazu-yamamoto
Copy link
Collaborator

Merged.

@ocheron ocheron deleted the psk-position branch July 17, 2019 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants