Check record alignment when changing Rx key #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When changing key with setRxState the implementation now verifies that the context is clean and all content decrypted with the previous key has been consumed. There must be no partial handshake fragment left for decoding, and no decoded handshake message that is not consumed by pending actions or RecvHandshake13M.
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each time the Rx key is modified with
setRxStatewe can verify that there is no message deprotected with the previous key still unconsumed. This includes verifying the tail of a received[Handshake13]packet as well as incomplete handshake fragments stored in the context.