Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort 0-RTT connection without TLS13 #388

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Abort 0-RTT connection without TLS13 #388

merged 1 commit into from
Jul 25, 2019

Conversation

ocheron
Copy link
Contributor

@ocheron ocheron commented Jul 24, 2019

Having a dedicated error in case of deployment issue will allow to understand the cause more easily, i.e. without requiring to capture server hello.

To analyze deployment issues more easily, this adds the backward
compatibility requirement from RFC 8446 section D.3:

   A client that attempts to send 0-RTT data MUST fail a connection if
   it receives a ServerHello with TLS 1.2 or older.
@kazu-yamamoto kazu-yamamoto self-requested a review July 25, 2019 00:41
Copy link
Collaborator

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kazu-yamamoto added a commit to kazu-yamamoto/hs-tls that referenced this pull request Jul 25, 2019
@kazu-yamamoto kazu-yamamoto merged commit 7607e37 into haskell-tls:master Jul 25, 2019
@kazu-yamamoto
Copy link
Collaborator

Merged.

@ocheron ocheron deleted the rtt0-without-13 branch July 26, 2019 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants